Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove children during on_remove #7

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove children during on_remove #7

wants to merge 4 commits into from

Conversation

matthunz
Copy link

@matthunz matthunz commented Nov 5, 2024 •
edited
Loading

Fixes #6

Adds on_remove hooks for:

  • WithChild
  • WithChildren

@matthunz matthunz marked this pull request as ready for review November 5, 2024 01:00
@alice-i-cecile
Copy link
Contributor

Once WithChildren is done too I'd like to merge this :)

@alice-i-cecile alice-i-cecile added the bug Something isn't working label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove child components during on_remove
2 participants
@matthunz @alice-i-cecile