Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper method to Login class #639

Open
dpriskorn opened this issue Dec 7, 2023 · 2 comments
Open

Add helper method to Login class #639

dpriskorn opened this issue Dec 7, 2023 · 2 comments
Assignees

Comments

@dpriskorn
Copy link
Contributor

The current way of handling login seems broken. If I create a Login() object I have no way of knowing whether the login was successful or not.

How do we fix this so that it is dead simple?

I suggest helper method to the Login class. That way I can try logging in first and check if successful.

@LeMyst
Copy link
Owner

LeMyst commented Dec 9, 2023

Hello @dpriskorn

When I try to set a wrong username/password/URL I always end with an adequate Exception.

Do you have an example where the Exception is not ideal?

Thank you

@dpriskorn
Copy link
Contributor Author

dpriskorn commented Dec 11, 2023

Nope, my problem was because I put the login in a method that was never reached because of a bug in my code.
Anyway I suggest we reconsider how we want configuration and Login to work.
Ideally I would like to check on all WBI objects if a connection is present and if logged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants