Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 180 degrees to isRotated logic #177

Open
gmr-renato opened this issue Dec 27, 2023 · 2 comments
Open

Add 180 degrees to isRotated logic #177

gmr-renato opened this issue Dec 27, 2023 · 2 comments

Comments

@gmr-renato
Copy link

gmr-renato commented Dec 27, 2023

I'm using the package for a personal project and I notice this:

lib/src/controller line 417:

bool get isRotated => rotation == 90 || rotation == 270;

The right logict should be:

bool get isRotated => rotation == 90 || rotation == 270 || rotation == 180;
or
bool get isRotated => rotation != 0;

image

@gabrieluca
Copy link

I've had issues with this as well!

@gabrielscr
Copy link

Same issues here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants