Entry template with production build

[PeterKottas]

Guys, thanks for rescuing this useful package! There is however one serious issue. I actually wonder how am I the only one seeing this?!

When you use an entry template, in development mode, all works as expected, however, once you switch to production mode in webpack, all hell breaks loose. Apparently, it somehow removes all callbacks from listeners. I've never seen anything like this before, but that seems to be the case.

I've made a minimal repo: https://github.com/PeterKottas/offline-plugin-webpack-5

Long story short, my template is this:

const constFunction = () => {
  console.log("constFunction");
};
self.addEventListener("push", constFunction);
self.addEventListener("notificationclick", () => {
  console.log("inlineFunction");
});
self.addEventListener("message", function () {
  console.log("function");
});

But when compiled in production mode, the above becomes:

// Code omitted
self.addEventListener("push", () => {}),
self.addEventListener("notificationclick", () => {}),
self.addEventListener("message", function () {});
// Code omitted

Please try for yourself, simply run "npm run build-dev", confirm that the code ends up in the final sw.js, then run "npm run build-prod" and you will see that the callbacks are stripped away. Any ideas? Thanks

[PeterKottas]

I do feel like this has something to do with this file: https://github.com/LeComptoirDesPharmacies/offline-plugin/blob/master/src/misc/get-minification-plugin.js
There's some weird logic regarding minification that might be outdated. I will continue looking

[PeterKottas]

So apparently the problem is https://github.com/LeComptoirDesPharmacies/offline-plugin/blob/master/src/service-worker.js#L75. Due to the way the loader is coded, drop_console will apparently remove callback functions. Fixed by #9 . I would greatly appreciate if you could take a look and merge if everything makes sense. Many thanks!

[PeterKottas]

I don't have a good feeling ... seems like forked died as well. Is this lib cursed or what :D Well anyways, I will remain hopeful you will reply. If not, I'll just release this under our handle.