Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into serialization of the action stack #23

Open
LeCodex opened this issue Nov 29, 2024 · 3 comments
Open

Look into serialization of the action stack #23

LeCodex opened this issue Nov 29, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@LeCodex
Copy link
Owner

LeCodex commented Nov 29, 2024

Currently games that never empty the stack will never have more than one "starting point" for reverts, which may lead to long delays as the game has to replay every action. Serializing and saving the stack (or finding an alternative method of handling actions) would allow for saves to happen at any point

@LeCodex LeCodex added the enhancement New feature or request label Nov 29, 2024
@LeCodex LeCodex self-assigned this Nov 29, 2024
@LeCodex
Copy link
Owner Author

LeCodex commented Nov 29, 2024

Some of those actions include callback functions for them to be more generic. This makes them very hard to serialize and parse properly
Those could be bundled into new classes that contain the callback

@LeCodex
Copy link
Owner Author

LeCodex commented Jan 2, 2025

Necessary to allow for failed reloads to use a "final state" that doesn't require saving on an empty stack

@LeCodex
Copy link
Owner Author

LeCodex commented Jan 2, 2025

Currently impossible since effects have been reworked to be actions with callbacks

@LeCodex LeCodex added the wontfix This will not be worked on label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant