Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages #13

Open
cristian9751 opened this issue Sep 11, 2024 · 2 comments
Open

Error messages #13

cristian9751 opened this issue Sep 11, 2024 · 2 comments
Labels
refactor Refactoring issue

Comments

@cristian9751
Copy link

You should implement another layer to catch the error and present a messsage not the plain exception

@LazoYoung
Copy link
Owner

LazoYoung commented Sep 11, 2024

You should implement another layer to catch the error and present a messsage not the plain exception

Thanks for the comment but would you mention the line of code that you concern please. @cristian9751

@LazoYoung
Copy link
Owner

LazoYoung commented Sep 11, 2024

this.logger.log(Level.SEVERE, "Failed to connect!", t);

If this part is your concern, presenting the error by using logger.log() was intentional as the logger is hooked by a LogHandler to present every warnings or stacktraces on the console page of this application. Users can check the console to review the error if desired. Also, alert window pops up automatically when a SEVERE log is printed to the console.
You can check the code here. Do you think I need a different approach to deal with errors?

@LazoYoung LazoYoung added the refactor Refactoring issue label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring issue
Projects
None yet
Development

No branches or pull requests

2 participants