[v2] integrate with new payments contract #995
+343
−301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
force-pushed
the
hope/new-payments-contract
branch
from
e849753 to
cd399d4
Compare
ian-shim
reviewed
Dec 12, 2024
| @@ -210,6 +210,18 @@ func (t *Reader) updateContractBindings(blsOperatorStateRetrieverAddr, eigenDASe | |||
| } | |||
| } | |||
|
|
|||
| paymentVaultAddr, err := contractEigenDAServiceManager.PaymentVault(&bind.CallOpts{}) | |||
| if err != nil { | |||
There was a problem hiding this comment.
let's not fail and account for the case contract isn't deployed like threshold registry above
There was a problem hiding this comment.
okay, edited to just log
core/eth/reader.go
Outdated
| @@ -691,9 +703,6 @@ func (t *Reader) GetAllVersionedBlobParams(ctx context.Context) (map[uint16]*cor | |||
| } | |||
|
|
|||
| func (t *Reader) GetReservedPayments(ctx context.Context, accountIDs []gethcommon.Address) (map[gethcommon.Address]*core.ReservedPayment, error) { | |||
| if t.bindings.PaymentVault == nil { | |||
There was a problem hiding this comment.
let's keep them until contract is deployed on mainnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Generated new contract bindings
Updated to corresponding names
Update contract bindings to include payment vault initialization
Checks