Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Update blob header hasher #962

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[v2] Update blob header hasher #962

merged 1 commit into from
Dec 12, 2024
+124 −116

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Dec 5, 2024 •
edited
Loading

Why are these changes needed?

  • uses uint16 for blob versions instead of uint8
  • updates blob header hasher based on 76b4395

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested review from mooselumph and 0x0aa0 December 5, 2024 05:33
@ian-shim ian-shim marked this pull request as ready for review December 5, 2024 05:34
@ian-shim ian-shim force-pushed the blob-header-hash branch 3 times, most recently from a435e73 to 8a584f4 Compare December 11, 2024 23:17
mooselumph
mooselumph approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@mooselumph mooselumph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ian-shim ian-shim merged commit 1f84a21 into Layr-Labs:master Dec 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooselumph mooselumph mooselumph approved these changes

@0x0aa0 0x0aa0 Awaiting requested review from 0x0aa0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @mooselumph