Payments storage packing #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
0x0aa0
commented
Dec 2, 2024
•
0x0aa0
commented
- introduces new storage layout
- rename bin -> period
- link PaymentVault on DASM
ian-shim
reviewed
Dec 3, 2024
ian-shim
reviewed
Dec 3, 2024
hopeyen
reviewed
Dec 5, 2024
There was a problem hiding this comment.
DASM link looks good.
For storage packing, I think we can revert back to using uint256 for onDemandPayments and in the future we will need to add the collected amount to the same slot (like _onDemandPaymentsCollected_ || _onDemandPaymentsDeposited_. The current deposit function will only take a uint128 to update the lower slot, and a new collect function only callable by operators who supply a payment verification over the claimed collection.
Sorry that this is going back and forth a little bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.