Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will crash if sec-websocket-protocol has only one value #232

Open
zexee opened this issue Oct 13, 2017 · 0 comments
Open

Will crash if sec-websocket-protocol has only one value #232

zexee opened this issue Oct 13, 2017 · 0 comments

Comments

@zexee
Copy link

zexee commented Oct 13, 2017

protocols = ','.join(value)

I don't know much about websocket but when use this to connect libwebsocket-based server, it will crash, and the error comes from this line. The value is b'ws'. Simply change this line to protocols = value, and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant