Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Addition for Fandango #2133

Closed
wants to merge 2 commits into from

Conversation

dlelacheur81
Copy link

Click on the template that fits your PR

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Jun 2, 2024
@x9136
Copy link
Collaborator

x9136 commented Jun 3, 2024

Hey! Your icon is not suitable for Lawnicons. If you want to redo it, I suggest you first read the Lawnicons guidelines.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Jun 3, 2024
@dlelacheur81
Copy link
Author

I did read the guidelines before creating. Can you give more details on exactly what guidelines were not adhered to?

@x9136
Copy link
Collaborator

x9136 commented Jun 3, 2024

I did read the guidelines before creating.

I don't know what happened, considering how different the result is from the guidelines, so let's start by writing out the points from the TL;DR section that are currently not fulfilled:

  1. The content area for most icons is 160×160px, meaning the long side of an icon should be 160px.
  2. No fill, the stroke width is 12px.
  3. All shapes should be black #000 with rounded ends and joins.
  4. Round 90° angles by 6-32px.

In addition:

  1. The icon is shifted vertically downwards.
  2. The icon has a couple of extra backgrounds.
  3. The name of the drawable should begin with a small letter.
  4. The PR description is ignored.
    Regarding these points, you can see how everything is done in previously accepted PRs.

@I21b I21b mentioned this pull request Jun 14, 2024
1 task
This was referenced Jun 21, 2024
@x9136
Copy link
Collaborator

x9136 commented Jun 26, 2024

#2174

@x9136 x9136 closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants