lost and found refactor #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| FOUND = found_images_table | ||
|
|
||
|
|
||
| def insert_in_table(TableType, form_data: Dict[str, Any], user_id: int ): |
There was a problem hiding this comment.
here declare TableType like.
def insert_in_table(table_type: TableType,........)Make relevant changes at other places too.
| @@ -22,7 +22,7 @@ async def add_item( request: Request, | |||
| form_data_dict = json.loads(form_data) | |||
| user_id = get_user_id(request) | |||
| with conn.cursor() as cur: | |||
| cur.execute( insert_in_lost_table( form_data_dict, user_id ) ) | |||
| cur.execute( insert_in_table(0, form_data_dict, user_id ) ) | |||
There was a problem hiding this comment.
You were supposed to pass a TableType.LOST or TableType.FOUND, but you have passed integers, and it gives errors. Fix this error in all the files.
| class TableImagesType(Enum): | ||
| LOST = lost_images_table | ||
| FOUND = found_images_table | ||
|
|
There was a problem hiding this comment.
It's nice that you used enums. For uniformity, could you move these enums to models.py and make appropriate imports?
|
Closing this PR now. Kindly make a new PR on the backend branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves #11 by merging the
queries/lost.pyandqueries/found.pyintoqueries/lost_and_found.pyand changing the implementation in theRoutes/Lost_and_Found/files.I didn't merge the
Routes/files because it wasn't specified, but it doesn't look too hard to implement.