Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerPlayerEntity should be used instead of PlayerEntity #9

Open
Technici4n opened this issue Nov 12, 2021 · 2 comments
Open

ServerPlayerEntity should be used instead of PlayerEntity #9

Technici4n opened this issue Nov 12, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Technici4n
Copy link

Technici4n commented Nov 12, 2021

I think that would make it a lot clearer that the methods may only be called server-side. This is a breaking change though, but perhaps it would make sense for 1.18?

Edit: Just a suggestion of course.

@Pyrofab Pyrofab added the enhancement New feature or request label Nov 12, 2021
@Pyrofab
Copy link
Member

Pyrofab commented Nov 12, 2021

That would indeed make sense, but I believe with the pre-release out (and the 1.17 version being compatible with 1.18 already) it's a bit late to make breaking changes. I'll consider that for 1.19 though.

@Pyrofab
Copy link
Member

Pyrofab commented Aug 18, 2023

Update: I forgor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants