Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns that are missing in old clients #25

Open
7 tasks done
Xiphoseer opened this issue Jan 1, 2023 · 6 comments
Open
7 tasks done

Columns that are missing in old clients #25

Xiphoseer opened this issue Jan 1, 2023 · 6 comments

Comments

@Xiphoseer
Copy link
Collaborator

Xiphoseer commented Jan 1, 2023

We use paradox-typed-db based on 1.10.64, but we want ParadoxServer to work with old clients ideally. This issue is to track columns that were added recently that we should ignore completely if missing:

  • Activities:gate_version
  • DeletionRestrictions:gate_version
  • DestructibleComponent:factionList
  • ItemComponent:commendationLOT
  • MissionTasks:gate_version
  • Objects:_internalNotes
  • Objects:gate_version
@aronwk-aaron
Copy link
Contributor

aronwk-aaron commented Jan 2, 2023

  • Missions:isRandom
 INFO  paradox_server::api                > API Route: Rev(MissionTypeBySubTy(PercentDecoded("Battle"), PercentDecoded("General")))
The application panicked (crashed).
Message:  Missing column isRandom in Missions
Location: /tmp/cargo-installSeyNb9/release/build/paradox-typed-db-b8bb06966298c829/out/rows.rs:1

@Xiphoseer
Copy link
Collaborator Author

Missions:isRandom

Turns out this wasn't the same sort of bug, but an entirely different class that should be fixed now

@aronwk-aaron
Copy link
Contributor

I think this issue can be closed as we now have the oldest client in our possession up and running with lu-explorer

@Xiphoseer
Copy link
Collaborator Author

Xiphoseer commented Jan 4, 2023

Are there still warnings in the logs? The current code just doesn't crash under any circumstances, but that doesn't mean it doesn't try to read those columns anymore.

(ie paradox-typed-db is more forgiving now, but will still complain the server is calling it wrong)

@aronwk-aaron
Copy link
Contributor

oh right! I'll grab those logs and document what it is complaining about

@aronwk-aaron
Copy link
Contributor

These are the ones I see in logs

 WARN  paradox_typed_db::rows         > Missing column gate_version in ZoneTable
 WARN  paradox_typed_db::rows         > Missing column gate_version in SpeedchatMenu
 WARN  paradox_typed_db::rows         > Missing column gate_version in UgBehaviorSounds
 WARN  paradox_typed_db::rows         > Missing column gate_version in SkillBehavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants