#17 add SOM-based spec-z selection degrader #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just remembered that I need to write a test for this... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 322 377 +55
=========================================
+ Hits 322 377 +55 ☔ View full report in Codecov by Sentry. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #17, I added a spectroscopic degrader that trains a som based on input columns in a big test file, ingests a smaller reference file, classifies both sets into best SOM cells, then iterates through all SOM cells and tries to match the number of reference objects with a random selection of input objects for that cell, which should naturally mimic the properties of the reference data.
I included an example notebook, and I just ran the degrader on 6 million Roman-DESC objects and the 430,000 HSC galaxies, and results look good, so I think everything is working.
The biggest issue is that I'm bad at naming things, so whoever reviews should make any suggestions on config parameter names e.g.
noncolor_cols,noncolor_nondet, etc...Code Quality
#pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added