Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color cut in CLF test should work on catalogs that have redshift blocks #121

Closed
yymao opened this issue Jun 23, 2018 · 2 comments · Fixed by #122
Closed

color cut in CLF test should work on catalogs that have redshift blocks #121

yymao opened this issue Jun 23, 2018 · 2 comments · Fixed by #122
Assignees
Labels

Comments

@yymao
Copy link
Member

yymao commented Jun 23, 2018

This issue that @evevkovacs encountered was due to the fact that the color cut implementation in the CLF test assumes the catalog does not iterate over redshift blocks. When a catalog iterates over redshift blocks, some blocks may not have the redshift ranges needed to determine the color cut, and hence results in error.

This can be fixed if the test first determine the color cut using all blocks.

@yymao yymao added the bug label Jun 23, 2018
@yymao yymao self-assigned this Jun 23, 2018
@evevkovacs
Copy link
Contributor

Wouldn't it be sufficient to have the test read in the catalog using the iterator (as in the dN/dz test)? This modification will have to be made for the test to work on cosmoDC2 in any case.

@yymao
Copy link
Member Author

yymao commented Jun 23, 2018

Sorry if I wasn't clear. The test is already using the iterator feature. However, it assumes that in each dataset that is being iterated over, low-z objects always exist. This is not the case for the cosmoDC2 reader as some datasets contain only high-z objects, and hence results in the test to break.

I'll fix this on Monday.

yymao added a commit that referenced this issue Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants