-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Querying massive galaxies as potential deflectors #251
base: main
Are you sure you want to change the base?
Conversation
…austic of a singular isothermal ellipsoid
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Hi @Vibhore-ARIES , Thank you very much for this PR! This PR has CI failure and also other fail. When you make iyt to pass these test, I will then review it. |
for more information, see https://pre-commit.ci
…nto light2mass
for more information, see https://pre-commit.ci
…nto light2mass
for more information, see https://pre-commit.ci
…nto light2mass
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 97.89% 95.46% -2.44%
==========================================
Files 70 73 +3
Lines 4652 5001 +349
==========================================
+ Hits 4554 4774 +220
- Misses 98 227 +129
|
Hi @nkhadka21, thanks. Yes, I am fixing those issues. |
|
||
def find_potential_lenses( | ||
foreground_table, | ||
background_source, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, we should find potential deflector galaxies (mostly massive elliptical) from the DC2 catalog. Then, you can use these selected deflectors in LensPop.
In this PR, I have added a script(s) to SLSim, to query massive elliptical galaxies and identify which of them can act as potential deflectors based on the angular cross section, source luminosity function and their magnitudes and redshift etc.
The following scripts are added in this PR: