Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querying massive galaxies as potential deflectors #251

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

Vibhore-ARIES
Copy link
Contributor

In this PR, I have added a script(s) to SLSim, to query massive elliptical galaxies and identify which of them can act as potential deflectors based on the angular cross section, source luminosity function and their magnitudes and redshift etc.

The following scripts are added in this PR:

  1. 'query_galaxies_as_deflectors.py' to slsim/Deflectors/
  2. srcprop.py to slsim/
  3. 'srclensprop.py' to slsim/
  4. 'example_query_galaxies_as_deflectors.ipynb' to notebooks
  5. 'test_query_galaxies_as_deflectors.py' to slsim/tests/tests_Deflectors.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nkhadka21
Copy link
Collaborator

Hi @Vibhore-ARIES , Thank you very much for this PR! This PR has CI failure and also other fail. When you make iyt to pass these test, I will then review it.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 63.03725% with 129 lines in your changes missing coverage. Please review.

Project coverage is 95.46%. Comparing base (99f2118) to head (fbb9713).

Files with missing lines Patch % Lines
slsim/srcprop.py 54.32% 74 Missing ⚠️
slsim/Deflectors/query_galaxies_as_deflectors.py 60.49% 32 Missing ⚠️
slsim/srclensprop.py 78.30% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   97.89%   95.46%   -2.44%     
==========================================
  Files          70       73       +3     
  Lines        4652     5001     +349     
==========================================
+ Hits         4554     4774     +220     
- Misses         98      227     +129     
Files with missing lines Coverage Δ
slsim/srclensprop.py 78.30% <78.30%> (ø)
slsim/Deflectors/query_galaxies_as_deflectors.py 60.49% <60.49%> (ø)
slsim/srcprop.py 54.32% <54.32%> (ø)

@Vibhore-ARIES
Copy link
Contributor Author

Hi @Vibhore-ARIES , Thank you very much for this PR! This PR has CI failure and also other fail. When you make iyt to pass these test, I will then review it.

Hi @nkhadka21, thanks. Yes, I am fixing those issues.


def find_potential_lenses(
foreground_table,
background_source,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, we should find potential deflector galaxies (mostly massive elliptical) from the DC2 catalog. Then, you can use these selected deflectors in LensPop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants