Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Integrates Magisk even if selecting "No" to root question. #817

Closed
1 task done
StormProductionsMusic opened this issue Oct 21, 2024 · 0 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@StormProductionsMusic
Copy link

Steps to reproduce/复现步骤

  1. Run run.sh;
  2. Select "No" to the root question;
  3. In the output directory, the filename wll still mention "with-magisk" even though rooting was set to no.

Expected behaviour/预期行为

WSA should compile without Magisk

Actual behaviour/实际行为

Instead it generates with Magisk even though "No" was selected.

MagiskOnWSALocal commit full SHA/MagiskOnWSALocal 提交的完整哈希

I used git clone, don't know where to look for such info. Cloned just 30 minutes before posting this issue.

Linux distribution info/Linux 发行版信息

Ubuntu 22.04

Windows version/Windows 版本

Windows Insider build 27729.1000

Build Parameters/构建参数

Version requirement/版本要求

  • I am using latest commit of MagiskOnWSALocal/我正在使用最新 commit 的版本

Logs/日志

# Replace this line with the log / 将此行用日志替换
@StormProductionsMusic StormProductionsMusic added the bug Something isn't working label Oct 21, 2024
@Howard20181 Howard20181 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants