Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix last-updated-time retrieval logic #27

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix last-updated-time retrieval logic #27

wants to merge 2 commits into from

Conversation

ayeshLK
Copy link
Collaborator

@ayeshLK ayeshLK commented Oct 10, 2022 •
edited
Loading

Purpose

$subject

@manuranga
Copy link
Collaborator

I don't think sending currrent time is a good idea. Its basically showing wrong info when an error happens.
Better to make the return an optional value, and send null when its not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayeshLK @manuranga