Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated hard dependency shortid #5

Closed
micalevisk opened this issue Aug 29, 2021 · 2 comments
Closed

Replace deprecated hard dependency shortid #5

micalevisk opened this issue Aug 29, 2021 · 2 comments

Comments

@micalevisk
Copy link

"shortid": "^2.2.15"

async _subscribe(groupName, consumerName, handler, pollSpan = 1000, payloadsToFetch = 2, subscriptionHandle = shortid.generate(), readPending = false) {

2. [shortid](https://www.npmjs.com/package/shortid) for auto generating subscribtion handles.

image

You could use the lib nanoid

@micalevisk
Copy link
Author

btw you could replace redis-scripto with redis-scripto2 (which is an up-to-date fork) due to this security issue: arunoda/node-redis-scripto#9

@LRagji
Copy link
Owner

LRagji commented Aug 30, 2021

Thanks give me some time will check and upgrade...

@LRagji LRagji closed this as completed in debafb4 Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants