Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch syntax / variant checker on LOVD.nl #575

Closed
14 tasks done
ifokkema opened this issue Nov 24, 2021 · 0 comments · Fixed by #587
Closed
14 tasks done

Batch syntax / variant checker on LOVD.nl #575

ifokkema opened this issue Nov 24, 2021 · 0 comments · Fixed by #587

Comments

@ifokkema
Copy link
Member

ifokkema commented Nov 24, 2021

Depends on #573.

Create an interface that:

  • Works on the website. Since the LOVD.nl code is not (yet) versioned, either develop in LOVD's scripts folder or create a private LOVD.nl repository. Probably the former.
  • Allows both syntax and variant validation, to be chosen by the user. Syntax check is fast, variant validation will be slower.
    • Syntax validation is always done first. When we have validated (and possibly improved) the syntax, the variant may also be sent to VV, which can in turn actually validate the variant itself. VV may also correct the description. Note that for variant validation, a reference sequence is required.
    • Hold off supporting LRGs or NGs right now, as VV doesn't support them well yet.
  • Allows both for one-variant checks as well as a list of variants.
    • The list may be populated by copy/paste or the upload of a document.
  • Results should be written to the screen, but should also become downloadable.
  • Results should include;
    • The input
    • The corrected output
    • Whether there was a problem or not
    • Detailed error messages.
  • It would be good to study the VV output format, so we can align our formats.
  • Perhaps, due to time constraints, it would be good to first have the syntax checker working and online, and work on the rest after.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant