Add support for static entropy #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
added
feature
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
zoedberg
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Looks good but there are some warnings that may be addressed:
warning: unnecessary `pub(self)`
--> commit_verify/src/lib.rs:48:1
|
48 | pub(self) mod commit;
| ^^^^^^^^^ help: remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: `#[warn(clippy::needless_pub_self)]` on by default
warning: unnecessary `pub(self)`
--> commit_verify/src/lib.rs:51:1
|
51 | pub(self) mod embed;
| ^^^^^^^^^ help: remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
--> commit_verify/src/mpc/block.rs:123:27
|
123 | pub fn to_merkle_node(&self) -> MerkleNode {
| ^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `#[warn(clippy::wrong_self_convention)]` on by default
As said in BP-WG/bp-core#56 (comment) I think clippy should fail when there are warnings
|
This should help with unit testing, I would think |
|
@zoedberg already fixed in previously merged PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to target it for v0.11 since it breaks APIs - and there is no way of adding support for the feature without the API break