Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

Commit

Permalink
Merge pull request #411 from cryptagoras/patch-1
Browse files Browse the repository at this point in the history
docs(readme): note potential loss of precision
  • Loading branch information
mrfelton authored Feb 10, 2022
2 parents 28a2450 + 43a3738 commit 9a0eee3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ Under the hood we use the [`grpc-js`](https://github.com/grpc/grpc-node/tree/mas
oneofs: true,
}
```
(Note: when dealing with channel IDs and other fields that can exceed JavaScript's Number.MAX_SAFE_INTEGER, loss of precision can occur. This can be avoided by using `longs: String` on the above gRPC options and dealing with `String`s instead of `Number`s.)

These settings can be overridden by passing `grpcOptions` to the constructor. Custom settings will be merged in with the above defaults.

Expand Down

0 comments on commit 9a0eee3

Please sign in to comment.