feat: cayenne remappings #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshLong145
approved these changes
May 4, 2024
Comment on lines
+749
to
+751
| `${CAYENNE_URL}:7370'`, | ||
| `${CAYENNE_URL}:7371'`, | ||
| `${CAYENNE_URL}:7372'`, |
There was a problem hiding this comment.
just curious why did we make this change?
There was a problem hiding this comment.
This array is actually not used anymore, we can remove it. I didn't because there are interfaces/types are relying on it? Need to investigate
There was a problem hiding this comment.
Ah okay i was thinking it could be removed now. Making a note of this for myself @joshLong145
|
Just leaving a note to re run linting. but looks good :) |
yea, wil need to re-run them in the staging branch anyway |
Ansonhkg
merged commit cff71ba
into
feature/lit-2958-auth-unification-ts-tests
1 of 2 checks passed
Ansonhkg
deleted the
feature/lit-3100-auth-uni-create-a-mapping-for-cayenne-port-from-73xx-74xx
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remap
https://cayenne.litgateway.com/tohttp://207.244.70.36:7474/using staking contract port numbers & google dns resolver to get the ip address from the root domain name (without https), then when requesting session sigs, i need to remaphttp://207.244.70.36:7474/back to127.0.0.1:7474to be signed in the siwe messageType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: