Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(chain): add 'lit' to supported chains in constant.ts file #445

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

Aaryan-R-S
Copy link
Contributor

@Aaryan-R-S Aaryan-R-S commented Apr 27, 2024

Description

Add lit(Chronicle) to the supported chains page.

Adding to docs is done automatically using script. But it appears lit as an supported chain is missing from constants.ts

As @glitch003 suggested, let's add a new chain in constants.ts with the name lit, with the same exact data as the chronicleTestnet entry. Then, once the new SDK is published, any commit to the docs repo will automatically pull down the latest version of the SDK and regenerate the list of supported chains in the doc (it's a pre-commit hook in the docs repo).

Fixes: LIT-2927

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Aaryan-R-S Aaryan-R-S marked this pull request as ready for review April 27, 2024 03:09
Copy link
Collaborator

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aaryan-R-S
Could you also please open a PR here:
https://github.com/LIT-Protocol/accs-schemas

You can check my previous PR to see how I added a new chain

The SDK uses the ^ for the accs package, so any new patch update from the accs package would be updated in the JS-SDK automatically

@joshLong145 joshLong145 merged commit fa880fb into master Apr 29, 2024
3 of 4 checks passed
@joshLong145 joshLong145 deleted the addNewChain branch April 29, 2024 14:50
@Aaryan-R-S
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants