Feature/lit 3017 auth unification migrate actual tests #440
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -244,6 +244,11 @@ export interface BaseJsonExecutionRequest { | |
| authMethods?: AuthMethod[]; | ||
| } | ||
|
|
||
| /** | ||
| * FIXME: We should create a separate interface for JsExecutionRequestBody | ||
| * a body that the SDK accepts, and another one the node actually accepts. | ||
|
There was a problem hiding this comment. Why can't we have a single interface? |
||
| * | ||
| */ | ||
| export interface WithAuthSig extends BaseJsonExecutionRequest { | ||
| authSig: AuthSig; | ||
| sessionSigs?: any; | ||
|
|
@@ -257,7 +262,7 @@ export interface WithSessionSigs extends BaseJsonExecutionRequest { | |
| export type JsonExecutionRequest = WithAuthSig | WithSessionSigs; | ||
|
|
||
| export interface JsExecutionRequestBody { | ||
Ansonhkg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| authSig: AuthSig; | ||
| code?: string; | ||
| ipfsId?: string; | ||
| authMethods?: AuthMethod[]; | ||
|
There was a problem hiding this comment. You can't provide authMethod any more There was a problem hiding this comment. @Ansonhkg this comment is remaining? |
||
|
|
@@ -313,7 +318,6 @@ export interface JsonSignSessionKeyRequestV1 { | |
| sessionKey: string; | ||
| authMethods: AuthMethod[]; | ||
| pkpPublicKey?: string; | ||
| siweMessage: string; | ||
| curveType: 'BLS'; | ||
| code?: string; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ansonhkg Can you please double check all you interfaces against the node counter parts eg: https://github.com/LIT-Protocol/lit-assets/blob/aff82c4381139476aeaa6faa814069b184d38d39/rust/lit-node/src/models/mod.rs#L177
Note, some params are still accepted in the nodes for backwards compatible reasons but they don't need to be present in the SDK as we're not making the SDK backwards compatible with the older node versions
For instance, we don't allow passing an AuthSig for signSessionKey: https://github.com/LIT-Protocol/lit-assets/blob/aff82c4381139476aeaa6faa814069b184d38d39/rust/lit-node/src/endpoints/versions/v1.rs#L59
There are bunch of other restrictions for the v1 endpoint in the above node file. We should make the SDK interfaces compatible with those restriction as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ansonhkg this comment is remaining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea has been addressed in one of the comments below, will double check again here #435