Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc strings for GetSessionSigsProps #431

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

gilbert
Copy link
Contributor

@gilbert gilbert commented Apr 18, 2024

Description

TypeScript displays /** ... */ comments on properties but ignores // ... comments. This PR fixes comment docs for a single interface (the one I'm currently dealing with).

Also added an example for the expiration field.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Ansonhkg Ansonhkg merged commit 810558b into LIT-Protocol:master Apr 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants