Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get generated stuff out of PRs to make them cleaner #395

Merged
merged 8 commits into from
Mar 12, 2024

Conversation

glitch003
Copy link
Collaborator

@glitch003 glitch003 commented Mar 7, 2024

I want to get all the generated code out of PR's, so that the PR only contains the code changes themselves.

This is a first pass at this:

  • Remove any version info from the generated readme. Instead, we use NPM badges that just show the latest version.
  • Remove "last modified" time from autogen_internal-dev.js - this info is in git already
  • Run prettier after build, so that our checked in code and our generated JSON files all match

@glitch003 glitch003 changed the title Feature/generated stuff out of git Get generated stuff out of PRs to make them cleaner Mar 7, 2024
Copy link
Contributor

@MaximusHaximus MaximusHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 less churn on standard builds is a good thing IMO :) LGTM

@Ansonhkg Ansonhkg mentioned this pull request Mar 12, 2024
5 tasks
@Ansonhkg Ansonhkg changed the base branch from master to staging/3.2.6 March 12, 2024 06:29
Copy link
Collaborator

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Ansonhkg Ansonhkg merged commit ed78521 into staging/3.2.6 Mar 12, 2024
3 of 4 checks passed
@Ansonhkg Ansonhkg deleted the feature/generated-stuff-out-of-git branch March 12, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants