Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lit 2493 js sdk remove vanilla packages #369

Closed

Conversation

Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Feb 19, 2024

Description

Removing vanilla js builds due to low usage, this should reduce around 30 seconds (125s -> 95s) in build time.

Type of change

  • Build

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ Ansonhkg
❌ Garandor
❌ cairomassimo
You have signed the CLA already but the status is still pending? Let us recheck it.

@Ansonhkg Ansonhkg marked this pull request as ready for review February 19, 2024 15:39
@Ansonhkg Ansonhkg mentioned this pull request Feb 19, 2024
5 tasks
@Ansonhkg Ansonhkg mentioned this pull request Feb 19, 2024
5 tasks
@Ansonhkg Ansonhkg deleted the branch staging/3.1.5 February 19, 2024 16:09
@Ansonhkg Ansonhkg closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants