Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
replaces
ethers.utils.hashMessage
with a non secure 32 bit hash function which has a low collision chance but quick throughput. This does mean the hashing function is non secure, meaning it is possible to reverse hashes in reasonable time. However we do need a secure hashing implementation for the purposes of the logger.Test times are observed to be the same and in some cases 100 - 200ms faster measurement was done with
logger.spec.ts
tests with both hashing implementations.Type of change
How Has This Been Tested?
logger.spec.ts
was run against the new hashing functionChecklist: