Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lit-siwe #365

Closed
wants to merge 8 commits into from
Closed

remove lit-siwe #365

wants to merge 8 commits into from

Conversation

glitch003
Copy link
Collaborator

lit-siwe was created to shrink the size of the siwe lib. but we're importing the new version of the siwe lib anyway, so lit-siwe actually just makes everything bigger. we need the new siwe to be compatible with siwe-recap, so we can't really avoid importing the normal siwe.

so this PR just removes lit-siwe and replaces it with normal siwe

@Ansonhkg Ansonhkg mentioned this pull request Feb 17, 2024
5 tasks
@Ansonhkg Ansonhkg changed the base branch from master to staging/3.1.5 February 18, 2024 20:40
@Ansonhkg Ansonhkg marked this pull request as ready for review February 19, 2024 15:55
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ Ansonhkg
✅ glitch003
❌ Garandor
❌ cairomassimo
You have signed the CLA already but the status is still pending? Let us recheck it.

@Ansonhkg Ansonhkg mentioned this pull request Feb 19, 2024
5 tasks
@Ansonhkg Ansonhkg deleted the branch staging/3.1.5 February 19, 2024 16:09
@Ansonhkg Ansonhkg closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants