Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref/run sev att check on mainnets #339

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

joshLong145
Copy link

@joshLong145 joshLong145 commented Feb 1, 2024

Description

Fixes an issue where on main net networks checkSevSnpAttestation may be disabled. new check will ignore the flag if the litNetwork is set to manzano or habanero

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@joshLong145 joshLong145 requested a review from Ansonhkg as a code owner February 1, 2024 21:14
Copy link
Collaborator

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ansonhkg Ansonhkg changed the base branch from master to staging/2024-02-06 February 2, 2024 12:38
@Ansonhkg Ansonhkg merged commit 55362f1 into staging/2024-02-06 Feb 2, 2024
4 checks passed
@Ansonhkg Ansonhkg deleted the ref/run-sev-att-check-on-mainnets branch February 2, 2024 12:39
@Ansonhkg Ansonhkg mentioned this pull request Feb 2, 2024
5 tasks
Ansonhkg added a commit that referenced this pull request Feb 6, 2024
* make capacityDelegationAuthSig optional (#337)

* Ref/run sev att check on mainnets (#339)

* add sev snp att check by default on main nets

* fmt

* [LIT-2333] Add e2e test for initializing multiple clients (#331)

* Remove globals for loggers and client

This commit removes the following global variables:
logManager, logger, litConfig, litNodeClient

* Test e2e parallel connections to multiple networks

* Revert "Remove globals for loggers and client"

This reverts commit 14f35f0.

* Cleanup/logger (#332)

* aggregate logs under categories. allow for cross category tracing

* autogen

* fmt

* change log persistence to use request id's as keys for lookup

* fmt

* fmt

* fix logger creation

* fmt

* fmt

* Update/test token (#336)

* update token symbol

* fmt

* fmt

* fmt

* fix: rm console.log (#342)

* Fix logging tests in 3.1.2 staging (#343)

* fix logging tests

* fix category in test

* Published version: 3.1.2

---------

Signed-off-by: Anson <[email protected]>
Co-authored-by: Bean <[email protected]>
Co-authored-by: Massimo Cairo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants