Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pending] Feature/lit 1487 js sdk fix unit testing for 300cayenne #219

Conversation

Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Sep 20, 2023

Updated: See #221 integration branch where this branch is merged into #199

What

  • Migrating network call unit tests to e2e nodejs tests
  • Added a script to always look for latest contract addresses before build
    "build:packages": "yarn update:contracts && yarn tools check --no-empty-directories=true && yarn tools fixTsConfig && yarn reset && yarn tools --build --packages && yarn tools --postBuild && yarn tools --setup-local-dev && yarn postBuild:mapDepsToDist && yarn gen:readme && yarn build:verify",
  • Fixed minNodeCount in PKPBase 0734ff3
  • Added allowJs to tsconfig.spec.js cus Jest is running in TS env. 9a61eb6
  • Added a try/catch to find decimalPlaces in the access control humanizer to prevent it throwing error 471394b#diff-ac4447edd4b5dbebe38c9c02d1d5b28238f3654f5da6a53f190aa40964187af8R248-R255
  • Fixed multiple places to use runSign instead of runLitAction in pkp-ethers pkp-client

Where

./e2e-nodejs directory

Commands

  💡 Usage: yarn test:e2e:node
  
  🌍 ENVs:
      DEBUG=true yarn test:e2e:node (Enables debug mode)
      REAL_TX=true yarn test:e2e:node (Enables real tx that costs gas)

  🚩 Flags:
      --filter=<keyword> (Filters files by keyword)
      --group=<group> (Group is directory prefix, e.g., --group=pkp-ethers uses group-pkp-ethers)

@vercel vercel bot temporarily deployed to Preview – js-sdk September 21, 2023 16:02 Inactive
@Ansonhkg Ansonhkg changed the base branch from master to feat/sdk-v3 September 21, 2023 17:33
@vercel vercel bot temporarily deployed to Preview – js-sdk September 21, 2023 20:45 Inactive
@Ansonhkg Ansonhkg changed the title [WIP] Feature/lit 1487 js sdk fix unit testing for 300cayenne [Pending] Feature/lit 1487 js sdk fix unit testing for 300cayenne Sep 21, 2023
@Ansonhkg Ansonhkg requested a review from sarahzdev September 21, 2023 22:14
@Ansonhkg
Copy link
Collaborator Author

Updated: See #221 integration branch where this branch is merged into #199

@Ansonhkg Ansonhkg closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants