Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-logged in user shouldn't be able to unmap application terms #211

Open
TravisWalterLBNL opened this issue Nov 3, 2021 · 2 comments
Open
Assignees
Labels
bug Something isn't working medium priority

Comments

@TravisWalterLBNL
Copy link
Collaborator

Without logging in, I clicked on a public application term in a public application, and the application term was mapped to a composite term. I clicked the X next to the composite term and was able to unmap the application term (i.e., the button turned gray and now says "map to existing bedes term"). I shouldn't be able to unmap someone else's application terms, even if they are public. Public means other people can view it, but not edit it.

@TravisWalterLBNL
Copy link
Collaborator Author

Same issue when logged in as one user and being able to unmap a different user's application term.

@TravisWalterLBNL
Copy link
Collaborator Author

Downgraded from high priority to medium because the application term doesn't actually get unmapped. Initally, it appears as though it's unmapped, but if you go back to the list of application terms and refresh the page, the mapping is intact. So, this is really just a display issue. The desired behavior would be that the mapped term is grayed out (indicating it can't be modified, as with the application term name, description, etc.), and for nothing to happen if the user clicks the X by the mapped term name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium priority
Projects
None yet
Development

No branches or pull requests

2 participants