Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grands of babys are siblings #256

Open
mariopaolucci opened this issue Jul 20, 2021 · 1 comment
Open

Grands of babys are siblings #256

mariopaolucci opened this issue Jul 20, 2021 · 1 comment
Assignees
@mariopaolucci
Labels
bug Something isn't working

Comments

@mariopaolucci
Copy link
Contributor

In:

PROTON-OC/PROTON-OC.nlogo

Lines 923 to 926 in 09f7403

init-person-empty
ask [ offspring-link-neighbors ] of myself [
create-sibling-links-with other [ offspring-link-neighbors ] of myself
]

We should have used out-offspring, not all the neighbors; those include also the mother's parents and thus, you become sibling of your grands.
@mariopaolucci mariopaolucci added the bug Something isn't working label Jul 20, 2021
@mariopaolucci mariopaolucci self-assigned this Jul 20, 2021
mariopaolucci added a commit that referenced this issue Jul 20, 2021
@mariopaolucci
This works for me. We have undirected links now; this helped hammerin…
fe9be79 
…g out a couple of subtle bugs, that is, #257 and #256.

the main rationale, tho, was the disaster of #255, where the distance algorithm didn't flow upstream as expected. This is in the past now, with all undirected networks everywhere.
@mariopaolucci mariopaolucci mentioned this issue Jul 20, 2021
Merged
@mariopaolucci
Copy link
Contributor Author

closed by 5c04a16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariopaolucci mariopaolucci

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mariopaolucci