Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to subscribe settled invoices #61

Open
yzernik opened this issue Apr 25, 2022 · 3 comments
Open

Add API to subscribe settled invoices #61

yzernik opened this issue Apr 25, 2022 · 3 comments

Comments

@yzernik
Copy link

yzernik commented Apr 25, 2022

Something like the equivalent of SubscribeInvoices in LND: https://api.lightning.community/#subscribeinvoices

This will probably require gRPC, because it has a streaming response.

@johncantrell97
Copy link
Contributor

yeah we definitely need to add support for some grpc stream apis but for each one we add it needs to also have a websocket equivalent.

@johncantrell97
Copy link
Contributor

similar to how there is the generic NodeRequest/NodeResponse and AdminRequest/AdminResponse enums we will probably want generic mpsc::Channel's for sending/receiving this data over.

I think there probably needs to be an issue about setting up streaming apis in general that needs to happen in order to properly implement this and other endpoints.

@yzernik
Copy link
Author

yzernik commented May 8, 2022

An alternative way to implement this is to do what c-lightning does:
https://lightning.readthedocs.io/lightning-waitanyinvoice.7.html

The waitanyinvoice RPC command waits until an invoice is paid, then returns a single entry ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants