Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images broken #105

Open
pendragons-code opened this issue Apr 1, 2023 · 14 comments
Open

Images broken #105

pendragons-code opened this issue Apr 1, 2023 · 14 comments

Comments

@pendragons-code
Copy link

It seems that on april fools, the images seem to have been broken, due to the site adding cats. I'm not sure, but i was pulling get info from name and i got inconsistent results.

@pendragons-code
Copy link
Author

returns undefined

@pendragons-code
Copy link
Author

I checked the MAL site and it would seem that the april fools thing is over, and that the scraper cannot provide pictures.

I tried using "nisekoi and naruto"

@pendragons-code
Copy link
Author

image

@Aeden-B
Copy link
Contributor

Aeden-B commented Apr 7, 2023

Can you explain which method you use, I don't reproduce with getInfoFromName.

@pendragons-code
Copy link
Author

const malScraper = require('mal-scraper')
const name = 'nisekoi'

malScraper.getInfoFromName(name)
  .then((data) => console.log(data))
  .catch((err) => console.log(err))

@Aeden-B
Copy link
Contributor

Aeden-B commented Apr 10, 2023

I haven't the same result as you, there is an image in picture attribute :

{
  title: "Nisekoi",
  picture: "https://cdn.myanimelist.net/images/anime/13/75587.jpg",
  trailer: "https://www.youtube.com/embed/Pu-n_4CLXLA?enablejsapi=1&wmode=opaque&autoplay=1",
  englishTitle: "Nisekoi: False Love",
  japaneseTitle: "ニセコイ",
  synonyms: [
    "Nisekoi",
  ],
  type: "TV",
  episodes: "20",
  aired: "Jan 11, 2014 to May 24, 2014",
  premiered: "Winter 2014",
  broadcast: "Saturdays at 23:30 (JST)",
  producers: [
    "Aniplex",
    "Mainichi Broadcasting System",
    "Shueisha",
  ],
  studios: [
    "Shaft",
  ],
  source: "Manga",
  duration: "24 min. per ep.",
  rating: "PG-13 - Teens 13 or older",
  genres: [
    "Comedy",
    "Romance",
  ],
  status: "Finished Airing",
  score: "7.58",
  scoreStats: "scored by 633,092 users",
  ranked: "#1445",
  popularity: "#119",
  members: "1,120,199",
  favorites: "10,611",
  id: 18897,
  url: "https://myanimelist.net/anime/18897/Nisekoi",
}

@pendragons-code
Copy link
Author

I hate to be the person that cannot provide more details about a bug, but i really have no idea what is going on. I am very sorry.

@Kylart
Copy link
Owner

Kylart commented Apr 13, 2023

What country do you live in @pendragons-code? Maybe this is a problem with content blocked in your country. Though it would be weird with the details you've given me.

Is it still working with a previous mal-scraper version?

@pendragons-code
Copy link
Author

What country do you live in @pendragons-code? Maybe this is a problem with content blocked in your country. Though it would be weird with the details you've given me.

Is it still working with a previous mal-scraper version?

Singapore. Sorry for being late, and yes, in the older version(s) they are working.

@pendragons-code
Copy link
Author

I haven't the same result as you, there is an image in picture attribute :

{
  title: "Nisekoi",
  picture: "https://cdn.myanimelist.net/images/anime/13/75587.jpg",
  trailer: "https://www.youtube.com/embed/Pu-n_4CLXLA?enablejsapi=1&wmode=opaque&autoplay=1",
  englishTitle: "Nisekoi: False Love",
  japaneseTitle: "ニセコイ",
  synonyms: [
    "Nisekoi",
  ],
  type: "TV",
  episodes: "20",
  aired: "Jan 11, 2014 to May 24, 2014",
  premiered: "Winter 2014",
  broadcast: "Saturdays at 23:30 (JST)",
  producers: [
    "Aniplex",
    "Mainichi Broadcasting System",
    "Shueisha",
  ],
  studios: [
    "Shaft",
  ],
  source: "Manga",
  duration: "24 min. per ep.",
  rating: "PG-13 - Teens 13 or older",
  genres: [
    "Comedy",
    "Romance",
  ],
  status: "Finished Airing",
  score: "7.58",
  scoreStats: "scored by 633,092 users",
  ranked: "#1445",
  popularity: "#119",
  members: "1,120,199",
  favorites: "10,611",
  id: 18897,
  url: "https://myanimelist.net/anime/18897/Nisekoi",
}

It is interesting because the schema/response model is completely different from what I am getting.

Yes, as of 2 hours ago, I can confirm that the bug is still there.

@Kylart
Copy link
Owner

Kylart commented Apr 13, 2023

Oh! Are you using Typescript here @pendragons-code ?

@Kylart
Copy link
Owner

Kylart commented Apr 13, 2023

I can also vouch that on node.js, using your code

const malScraper = require('mal-scraper')
const name = 'nisekoi'

malScraper.getInfoFromName(name)
  .then((data) => console.log(data))
  .catch((err) => console.log(err))

I have the same results as @Aeden-B 🤔

The model is indeed different so I'm not sure if you are actually using. this code or something else 🤔

@pendragons-code
Copy link
Author

pendragons-code commented Apr 13, 2023 via email

@pendragons-code
Copy link
Author

hey @Aeden-B @Kylart you should put my issue to low priority, this seems to be only affecting me so far, I like your projects very much and if my small issue is holding you all down, that would be bad. I will try to figure it out by myself. I will post an answer here in the future, and you can close it if you want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants