[NodeBundle] Allow NodeMenuItem to be extended

[mwoynarski]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Fixed tickets

Altered the NodeMenu helper to instantiate new NodeMenuItems using a protected method so NodeMenuItem can be replaced or extended without the developer being forced to override every method in NodeMenu that creates a new instance.

[ProfessorKuma]

Hi @, your PR needs some changes

• It seems that our checklist is missing or incomplete
• your PR title should look like [SomeBundle] Fixed some code

[ProfessorKuma]

Hi @, your PR needs some changes

• This PR seems to need a milestone of a minor release.

[ProfessorKuma]

Hi @, your PR passed all our requirements.

Thank you for contributing!

[acrobat]

What would be the usecase to extend the node menu? What "feature" is missing or part need to be extendable?

[mwoynarski]

It's less about making NodeMenu extensible as it is making NodeMenuItem extensible.

A year and a half on, I don't recall all the intricacies of the problem, but the basic issue was that I had needed to alter the behaviour of the getChildren() method of NodeMenuItem to incorporate something from the PagesConfiguration service, but it isn't possible to replace the NodeMenuItem class without replacing the entirety of the NodeMenu helper due to all of the individual calls to new NodeMenuItem(). Converting NodeMenuItem to an interface and refactoring NodeMenu to offer a method for creating new menu items allows a developer to utilize their own replacement for NodeMenuItem by extending NodeMenu and overriding only the createMenuItem() method, rather than having to duplicate the entire class.