[AdminListBundle] Display associations when using viewAction() #2564
Conversation
| $accessor = PropertyAccess::createPropertyAccessor(); | ||
| foreach ($MetaData->fieldNames as $value) { | ||
| foreach ($metaData->getReflectionProperties() as $value => $reflectionProperty) { | ||
| $fields[$value] = $accessor->getValue($helper, $value); |
There was a problem hiding this comment.
You could add a check here to see if the object has a __toString method, otherwise skip the property. Something like
if (\is_object($value) && !method_exists($value, '__toString')) {
continue;
}There was a problem hiding this comment.
That would not return the expected results. The value could be returned by $accessor->getValue($helper, $value); without having __toString() implemented in the entity. Adding your suggestion would cause no values to be displayed.
I've just tested this with an entity that has relations without having __toString() implemented. It caused an error. But the error came from the method getStringValue() from AbstractAdminListConfigurator, because it just tries to access getName() on every entity in the collection (eventhough that most likely does not exist).
I get that you cant add this if it breaks rendering objects which don't have the __toString method. I think at this point it should only break for anyone who has overwritten the getStringValue() method, while not calling parent::getStringValue() and not taking in account the $result could be an instance of PersistentCollection. I don't know what the policy is that you guys have on this, but if this is not good enough then you can close this pull request :)
$MetaData->fieldNamesreturns a list of regular property names, it does not return names of association mappings. This causes all associations not to be shown when viewing an entity in the adminlist.$metaData->getReflectionProperties()returns all properties. Also addedkey | transto be able to translate the names of the properties when viewing the data.I'd like to add that this change could potentially cause an exception for anyone who has uses view option in an admin list, when their entity has assocations and those entities havent implemented __toString()