Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org-ql makes org-brain-goto slow #246

Closed
ionling opened this issue Jan 19, 2020 · 6 comments
Closed

org-ql makes org-brain-goto slow #246

ionling opened this issue Jan 19, 2020 · 6 comments

Comments

@ionling
Copy link

ionling commented Jan 19, 2020

With the newest version of org-brain, the org-ql war introduced. Each time I ran org-brain-goto command, org-ql open all my brain files (140 file entries, toal 414 entires), which make Emacs slow...

Anything help or optimization?

@Kungsgeten
Copy link
Owner

Hi! Yes, it is a bit slow on my computer too. The slow part is having to open all of the files. If you have stuff in org-mode-hook and find-file-hook it takes some time to open the files. It should be MUCH faster when you've run the command once, and all of the files are open. Is it still slow the second time you run it?

@Kungsgeten
Copy link
Owner

There's a bit of discussion at alphapapa/org-ql#88 if you're interested.

@ionling
Copy link
Author

ionling commented Jan 20, 2020

Thanks for your response.

I test it again. It spend about 1 second to open org-brain-goto (second time), 0.5 second with the old version in my computer. It's slower.

@namdnguyen
Copy link
Contributor

Wow, I read the discussion in the org-ql issue you linked. This is a difficult problem. I really appreciate the work you're putting in upstream to help improve performance for org-brain.

@Kungsgeten
Copy link
Owner

I've removed the org-ql dependency in the latest commit. Instead a simple cache has been implemented, so org-brain should be faster than before.

@namdnguyen
Copy link
Contributor

Oh, cool. I'll give it a try and report back my experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants