Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider how to enable relaxed config reloading #287

Open
wez opened this issue Sep 20, 2024 · 0 comments
Open

Consider how to enable relaxed config reloading #287

wez opened this issue Sep 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@wez
Copy link
Collaborator

wez commented Sep 20, 2024

the high level idea is that some users will find it desirable to have control over how strictly errors within the various configuration files should be treated.

  • Can we allow/prevent stale reads of cached data if the newly loaded data is bad
  • option to keep going when one of the set of data files is bad
  • control whether those settings apply to validation mode and/or the main operation of the server
  • how do we surface errors that have been suppressed in this cases, and is that itself another option?

This needs some thought before starting to work up the code around it.
@wez wez added the enhancement New feature or request label Sep 20, 2024
wez added a commit that referenced this issue Oct 2, 2024
@wez
shaping: allow granular control of how checks are reported
d31c0f2 
At the lower level, expose an options struct that allows control
over how various checks and conditions are reported out of the
attempt to load the set of shaping files.

Expose a separate list of errors, distinct from warnings.

Each check can either be ignored, a warning, or an error.

Errors cause validate-shaping and --validate mode to exit
with an error condition, whilst warnings are simply emitted
as informational items.

In the shaping helper, it is possible to configure a separate set of
options for the main live service and validation mode, which allows you
to run a more relaxed configuration by default, but be a bit more strict
in your pre-commit and pre-deploy configuration validation pipeline

refs: #287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wez