Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Add Accepted status condition to DNSPolicy #640

Closed
4 tasks
maleck13 opened this issue Oct 26, 2023 · 3 comments
Closed
4 tasks

Add Accepted status condition to DNSPolicy #640

maleck13 opened this issue Oct 26, 2023 · 3 comments
Assignees
Labels
Milestone

Comments

@maleck13
Copy link
Contributor

maleck13 commented Oct 26, 2023

What

Based on https://github.com/Kuadrant/architecture/blob/main/rfcs/0004-policy-status.md we want to have some consistent status in place.

One of those status conditions is the Ready condition which is already present in DNSPolicy.

But we want to change that to a new condition Accepted this is in affect that the controller has validated that the policy is correct and valid and ready to be acted on. Things that may cause this not to be the case

  • DNSPolicy targeting a non gateway resource
  • DNSPolicy targeting a resource that has been deleted or not found
  • Another DNSPolicy being present and targeting the same ref

Done

@maleck13 maleck13 converted this from a draft issue Oct 26, 2023
@laurafitzgerald laurafitzgerald self-assigned this Nov 16, 2023
@laurafitzgerald laurafitzgerald moved this from Todo to In Progress in Multicluster Gateway Controller Nov 16, 2023
@maleck13 maleck13 added this to the v0.3.0 milestone Nov 21, 2023
@maleck13 maleck13 moved this to In Progress in Kuadrant Nov 21, 2023
@laurafitzgerald laurafitzgerald removed their assignment Dec 11, 2023
@laurafitzgerald
Copy link
Contributor

@sergioifg94 unassigning this one from myself, just fyi.

@sergioifg94 sergioifg94 self-assigned this Dec 11, 2023
@maleck13 maleck13 removed this from the v0.3.0 milestone Dec 11, 2023
@alexsnaps alexsnaps added this to the v0.4.0 milestone Dec 18, 2023
@philbrookes
Copy link
Contributor

This issue is stale because it has been open for 60 days with no activity.

@maleck13 maleck13 removed the stale label Feb 19, 2024
@sergioifg94 sergioifg94 moved this from In Progress to Done in Multicluster Gateway Controller Feb 20, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kuadrant Feb 26, 2024
@KevFan
Copy link
Contributor

KevFan commented Mar 4, 2024

Accepted Condition completed as part of Kuadrant/kuadrant-operator#416

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

No branches or pull requests

8 participants