Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --ratio and other cmd line args defaults #272

Closed
alexsnaps opened this issue Mar 20, 2024 · 0 comments · Fixed by #274
Closed

Fix --ratio and other cmd line args defaults #272

alexsnaps opened this issue Mar 20, 2024 · 0 comments · Fixed by #274
Labels
kind/bug Something isn't working

Comments

@alexsnaps
Copy link
Member

All command line arguments' default should use the same defaults as the crate.
Currently, --ratio is using a non-sensible default, instead of the 10 the crate defines and which would make sense.
@alexsnaps alexsnaps added the kind/bug Something isn't working label Mar 20, 2024
@alexsnaps alexsnaps moved this to Todo in Kuadrant Mar 20, 2024
@alexsnaps alexsnaps mentioned this issue Mar 21, 2024
Merged
@alexsnaps alexsnaps moved this from Todo to Ready For Review in Kuadrant Mar 21, 2024
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Kuadrant Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmdline uses default values from crate, rather than its own Kuadrant/limitador
1 participant
@alexsnaps