-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Ribbon in .NET 6 (was 5) designer can't add a linegroup or anything else to a tab group #262
Comments
Check with #178 |
FYI, this problem is getting very difficult to manage. The workaround provided only works for simple projects. Anything remotely complex (e.g. with custom controls embedded into the form) starts becoming difficult, at best, and impossible at worst, to manage. Since I'm writing an API that allows users to write their own plug ins for this application this issue, makes it so others can't use my stuff without implementing a rather annoying hack to make it work which can require some intimate knowledge of how all this stuff works under the hood. Has there been any progress on getting this issue fixed? Would you like me to do some testing for you guys on this? |
It is really annoying - I agree.
Can you elaborate on your workaround ? |
It's just the standard workaround where you make the project target multiple frameworks, one for 4.8 and the other for 5.0. The other workaround where you link to a control/form in a separate .NET 4.8 project is even worse as soon as you add a single custom control and/or embedded resources. Within my project, the first workaround works fine, but when I try to use it outside of my project source code that's when it all breaks down. Because I do not ship out the 4.8 code, users cannot link against my APIs and they cannot access the ribbon and create their own ribbon interface using .net 5 - which is something that I really want to expose. I also tried a code-first approach where I started to create a ribbon builder, and that looked promising until I found that I could not access the controls by name via the control hierarchy in the ribbon. As for why I don't ship out the 4.8 projects: I have a lot of C# 9 code, and there's parts (e.g. major parts of the Record type) that just don't work in 4.8 regardless of langversion. I #ifdef those lines of code out, thus making the .NET 4.8 code unusable (but can still compile). If I had the ability to turn off the 4.8 framework, and the ribbon allowed me to set it up in the .NET 5 designer, then all of this would no longer be an issue. |
Thanks for the report.. I'll keep pushing to try to fix each time I do a PR. |
Thank you |
Yep, that's what I've been getting. I could be wrong, but that designer looks like it's a standard .NET designer? That could be why you're not seeing anything in the debugger? |
Sorry for the sidebar question. I'm preparing to upgrade a large net48 project to NET5. I'm hesitating since it uses krypton controls extensively throughout the application. I've been digging through the open issues to try and piece together any issues I might expect, but it's hard to determine what's remaining. Other than the issue presented above, is the next stable build of krypton expected to have any remaining NET5 designer or runtime bugs? I'm fine with targeting multiple frameworks if necessary. Or would it be safer to wait until next year? Thanks |
This is still a problem in |
|
@Smurf-IV thanks for the update. I just figured out that one of my libraries (OpenTK) does not play nice between framework and core, so I can't target multiple frameworks. If it's only the ribbon that has issues I could just handle UI changes programmatically. Do you know of any other designer issues with net5 krypton controls? |
FYI
|
Just checking in on this to see if there's been any progress on fixing the designer issue? Will you need the new Windows Forms SDK to make this work? |
Hi @Tape-Worm A discussion has been posted here #684 |
Hi @Tape-Worm Yes the new Windows Forms SDK will be needed to fix this, since Microsoft broke something in-between 4.8 and .NET Core. One solution that may work is to add 'net48' to your 'TargetFrameworks'. This will force the designer to use a previous version. |
I know this started with ".net5 ...." |
Hi. Any updates on this issue? |
Not really, everyone is waiting for this. |
Hi @jfriborg Can't really fix until the WinForms designer is properly fixed for .NET. |
Have MS finally enabled Designers ?? |
@Smurf-IV Does this need to be a new feature request to add/fix designers? |
I think this was supposed to be left open waiting for the MS, then it would be fixed against this. |
@Smurf-IV Great, if you come across any bug reports relating to this, please apply the 'designer' tag if not already applied |
To summarize: (Tested in VS 17.7.4, and using the 80.23.8.233 canary build)
The following exception is being thrown when using the "Debug dev" or "Debug Nuget" solutions; When opened in VS 17.8.p2: BUT |
Hi @Tape-Worm, @Smurf-IV & @Wagnerp What is the status of this ticket? |
It's been a long time since I last looked at this (probably 6 months to a year), but the last I checked it was still broken. From what I understood wagner and smurf were waiting on some sort of thing from Microsoft to aid in building custom components with designers (I know very little about it I'm afraid). |
Describe the bug
After adding a group to the tab in the ribbon, the next level of containers fail with an error about abstract classes.
To Reproduce
Expected behavior
Should allow adding of a line group, or other container types.
Screenshots
Screen shot available here:
#260 (comment)
The text was updated successfully, but these errors were encountered: