Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed v4 #2

Open
chaseconey opened this issue Feb 2, 2021 · 1 comment
Open

Embed v4 #2

chaseconey opened this issue Feb 2, 2021 · 1 comment

Comments

@chaseconey
Copy link

chaseconey commented Feb 2, 2021 •
edited
Loading

Hello there!

It looks like the package that this package depends (oscarotero/Embed) on has been heavily reworked and has some great new adapters in the newest version (v4). Any reason we wouldn't want to upgrade it?

I don't mind upgrading, but wouldn't want to put in a PR if there is a reason we wouldn't want to move forward.

Thanks
@Krato
Copy link
Owner

Krato commented Feb 27, 2021

For sure. I'm opened to PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Krato @chaseconey