-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up a handling mechanism to catch error messages when accessing Kibella's internal database or cache #103
Comments
As agreed with Matthieu after our call this morning, to begin with we will implement a response from the backend with the following format:
On the frontend, the message will be displayed as a red banner via a notifier. The error message related to this issue can be triggered at any of the following contexts in the Kibella client: |
This looks great! This is ok for me! |
TODO: (2020/08/22) Once the interface is able to handle the above JSON string with an error message to display, the backend should be adapted so that all error messages are sent using that JSON protocol; and probably additional error/warning messages should also be sent in order to provide the user with suitable information. For the adaptation of existing error messages, look for all calls to For new error messages, there are already some commented out in |
The frontend code now contains a little piece of code that cannot be transpiled using the standard "grunt dist" command because grunt does not support yet the new extended javascript syntax (using arrow-expression "=>"). More precisely, inside the file "interface/elasticsearch.angular.js", there is one usage of "=>" that prevents all "grunt dist" commands to work. This little piece of code needs to be converted back to "standard" javascript. Currently, to still be able to transpile the code, I follow these steps:
This is ugly. |
Also: no banner is displayed when the message is sent from the formRegisterTableSubmit.php script. |
This issue is related to a high-priority request by Frank that the backend sends an error message to the interface that any one of the internal databases/directories used by Kibella is not accessible (most likely because of limited permissions).
Quoting Frank's message on 14-Jul-2020:
I clarify here that the backend does send an error message to the interface already, but not in a format that can be handled by the interface (e.g. JSON).
--
NEXT STEP:
We need to coordinate the communication mechanism between the backend and the interface so that the latter can show a proper message to the end user.
The text was updated successfully, but these errors were encountered: