Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaining apply animatediff models per_block used to work, not anymore. #511

Open
dchatel opened this issue Dec 5, 2024 · 5 comments
Open
Labels
question Further information is requested

Comments

@dchatel
Copy link

dchatel commented Dec 5, 2024

Doing something like the image shown below used to work and give pretty amazing results before the last patch (I think this is related to the new model patcher), but now it only generate noise.
image

@Kosinkadink
Copy link
Owner

Thanks for the report, I'll try to replicate it on my end.

@Kosinkadink
Copy link
Owner

I am unable to replicate your issue with a similar setup, can you create a simple workflow that replicates the issue on your end? Workflow embedded in this image:
perblockdebug

@Kosinkadink Kosinkadink added the question Further information is requested label Dec 6, 2024
@dchatel
Copy link
Author

dchatel commented Dec 6, 2024

Apparently, this is caused by the order of any other node patching the model, like Uncond Zero, Rescale CFG, even LoraLoaderOnly.
For example, this cause the issue:
image
But this doesn't:
image

So, there's at least a workaround, but it worked either way before the patch. Is there a preferential order for Use Evolved Sampling node in principle (not talking about this "bug" if it's one) ?

@Kosinkadink
Copy link
Owner

Hmm, nothing on the AD side of things changed how the model_sampling is assigned (the beta_schedule drop-down), so something must have changed on the ComfyUI side. Thanks for looking into it, at some point this weekend I'll try to track down what changed and if it's possible to make the order not matter. What are the results like if you try to run without the uncond zero node at all?

@dchatel
Copy link
Author

dchatel commented Dec 6, 2024

Without any additional node patching the model, the results are a proper sequence of images, not noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants