Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve list performance (round 3rd) #1169

Closed
9 tasks done
nguyenduythuc opened this issue Nov 20, 2023 · 7 comments · Fixed by #1778
Closed
9 tasks done

Improve list performance (round 3rd) #1169

nguyenduythuc opened this issue Nov 20, 2023 · 7 comments · Fixed by #1778
Assignees
@Quangdm-cdm
Labels
enhancement New feature or request need-more-discussion
Milestone
Milestone 8

Comments

@nguyenduythuc
Copy link
Contributor

nguyenduythuc commented Nov 20, 2023 •
edited
Loading

Describe the task
Improve list performance (round 3rd):

Changes:

  • Change from Flatlist to Flashlist
  • Memorize callbacks in list
  • Define item height for list item

Apply for:

  • Token list
  • Customize list
  • NFT list: collection, collection detail, network
  • Crowdloan list
  • dApp list
  • Setting - Network list
  • Setting - Token list
  • Earning list: Position, pools, validator
  • Mission pool list

Next step:

  • Section list: History, browser home
@nguyenduythuc nguyenduythuc self-assigned this Nov 20, 2023
@nguyenduythuc nguyenduythuc added the enhancement New feature or request label Nov 20, 2023
@nguyenduythuc nguyenduythuc added this to the Milestone 7 milestone Nov 20, 2023
@nguyenduythuc nguyenduythuc modified the milestones: Milestone 7, Milestone 8 Nov 21, 2023
@ThaoNguyen998
Copy link

ThaoNguyen998 commented Nov 23, 2023 •
edited
Loading

Version test: v1.1.10(240)
Device test: Samsung S20 FE 5G

@nguyenduythuc nguyenduythuc mentioned this issue Mar 2, 2024
Closed
@nguyenduythuc nguyenduythuc linked a pull request Mar 2, 2024 that will close this issue
[issue-1169] Improve list performance (round 3rd) #1521
Closed
@lw-cdm lw-cdm assigned lw-cdm and unassigned nguyenduythuc Mar 6, 2024
@ThaoNguyen998
Copy link

ThaoNguyen998 commented Mar 7, 2024 •
edited by Quangdm-cdm
Loading

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-326-1521-merge-2024-03-04T04-25-08.ipa
Device test: IP 11

  • UI bug Select account

Image

@lw-cdm lw-cdm assigned Quangdm-cdm and unassigned lw-cdm May 27, 2024
@Quangdm-cdm
Copy link
Collaborator

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-326-1521-merge-2024-03-04T04-25-08.ipa Device test: IP 11

  • UI bug Select account

Image

Can't reproduce this bug in current version

@hieudd hieudd modified the milestones: Milestone 7, Milestone 8 Jun 27, 2024
@Quangdm-cdm Quangdm-cdm mentioned this issue Aug 29, 2024
Merged
@Quangdm-cdm Quangdm-cdm linked a pull request Aug 30, 2024 that will close this issue
Improve list performance (Round 3) #1778
Merged
@ThaoNguyen998
Copy link

ThaoNguyen998 commented Sep 4, 2024 •
edited by Quangdm-cdm
Loading

Version test: https://www.diawi.com/qrcode/link/AuZUo2
Device test: S20 FE 5G

  • Bug when export all account
    Actual: Do not select all account

    1169.mp4

  • Do not show list Mission pool

Image

  • UI bug on Select pool

Image

  • Do not show list pool on IOS

Image

@Sokol142196 Sokol142196 mentioned this issue Sep 9, 2024
Closed
3 tasks
@ThaoNguyen998
Copy link

ThaoNguyen998 commented Sep 10, 2024 •
edited by Quangdm-cdm
Loading

Version test: https://www.diawi.com/qrcode/link/afu1Up
Device test: MI 8 Lite

  • Bug on Address book

Image

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Sep 11, 2024 •
edited by Quangdm-cdm
Loading

Version test: https://www.diawi.com/qrcode/link/ax4Fve
Device test: IP 13
Checklist: https://www.notion.so/subwallet/Checklist-theo-issue-13c9e3215ec24762973dc680aec67198?pvs=4#ac0982d066414f54b1fc39b063867508

  • Bug on Website access details

Check action: Block this site/Connect all/ Disconnect all

1169.mov

@ThaoNguyen998
Copy link

Version test: https://www.diawi.com/qrcode/link/XFqjpH
Device test: IP 13

Validation passed for checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Quangdm-cdm Quangdm-cdm

Labels
enhancement New feature or request need-more-discussion
Projects
None yet
Milestone
Milestone 8
5 participants
@hieudd @nguyenduythuc @Quangdm-cdm @lw-cdm @ThaoNguyen998