Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: combine services across different httproutes for traditional routes #6711

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

address comments and add feature gate CombinedServicesFromDifferentHT…

ffa3bbf
Select commit
Loading
Failed to load commit list.
Open

feat: combine services across different httproutes for traditional routes #6711

address comments and add feature gate CombinedServicesFromDifferentHT…
ffa3bbf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 30, 2024 in 1s

78.2% (+0.3%) compared to f187f31

View this Pull Request on Codecov

78.2% (+0.3%) compared to f187f31

Details

Codecov Report

Attention: Patch coverage is 82.14936% with 98 lines in your changes missing coverage. Please review.

Project coverage is 78.2%. Comparing base (f187f31) to head (ffa3bbf).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...al/dataplane/translator/subtranslator/httproute.go 81.3% 66 Missing and 14 partials ⚠️
...l/dataplane/translator/subtranslator/backendref.go 84.6% 9 Missing and 3 partials ⚠️
...ternal/dataplane/translator/translate_httproute.go 76.9% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #6711     +/-   ##
=======================================
+ Coverage   77.8%   78.2%   +0.3%     
=======================================
  Files        204     205      +1     
  Lines      23870   24238    +368     
=======================================
+ Hits       18590   18965    +375     
+ Misses      4337    4318     -19     
- Partials     943     955     +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov