Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CustomEntity feature gate and enable the custom entity feature by default #6634

Open
2 tasks
randmonkey opened this issue Nov 7, 2024 · 1 comment
Open
2 tasks

Remove CustomEntity feature gate and enable the custom entity feature by default #6634

randmonkey opened this issue Nov 7, 2024 · 1 comment
Labels
area/CRD Changes in existing CRDs or introduction of new ones
Milestone
KIC v4.0.x

Comments

@randmonkey
Copy link
Contributor

randmonkey commented Nov 7, 2024 •
edited
Loading

Remove the CustomEntity feature gate and enable controller for custom entities by default.

Acceptance Criteria

  • CustomEntity is removed and related documents are updated
  • custom entity controller is enabled by default
@randmonkey randmonkey mentioned this issue Nov 7, 2024
Open
@randmonkey randmonkey added the area/CRD Changes in existing CRDs or introduction of new ones label Nov 7, 2024
@randmonkey randmonkey added this to the KIC v3.4.x milestone Nov 7, 2024
@lahabana lahabana added the release/required it is required that this be resolved before releasing label Nov 12, 2024
@pmalek
Copy link
Member

pmalek commented Nov 19, 2024 •
edited
Loading

I'm wondering if we actually want to remove the feature gate itself 🤔 This would be a breaking change for our users and we're not releasing a major but a minor version.

Historically I can see that we have removed feature gates in a major version (v3.0), e.g.:

Having said that I have nothing against graduating the feature but I believe we should leave the FG until next major release and only remove it then.

@programmer04 programmer04 modified the milestones: KIC v3.4.x, KIC v4.0.x Nov 20, 2024
@randmonkey randmonkey removed the release/required it is required that this be resolved before releasing label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/CRD Changes in existing CRDs or introduction of new ones
Projects
None yet
Milestone
KIC v4.0.x
Development

No branches or pull requests
4 participants
@lahabana @pmalek @programmer04 @randmonkey